Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content warning changes #1795

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Content warning changes #1795

merged 3 commits into from
Feb 10, 2025

Conversation

jamesbiggs
Copy link
Collaborator

About these changes

Remove display_content_warning, and just use custom_content_warning. Updated existing frontend to match.

How to check these changes

Where possible, provide guidance to help your reviewer

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@jamesbiggs jamesbiggs requested a review from ahosgood February 10, 2025 11:11
Copy link
Member

@ahosgood ahosgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me 🚀

@jamesbiggs jamesbiggs merged commit 50e1fb1 into develop Feb 10, 2025
7 checks passed
@jamesbiggs jamesbiggs deleted the feature/content-warning-changes branch February 10, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants