TDR-3326 Assign references to file/directories

[thanhz]

No description provided.

[TomJKing]

Looks good. Thanks. Some initial comments, after a quick look through.

Still thinking about the recursive method in the reference generator service. So there will be more comments after I've had a more detailed look at the code.

[TomJKing]

Some additional comments. Thanks

[TomJKing]

I would abstract out some of this code from the getReferences method, to make it a little clearer, ie so that it is doing one thing.

Some thing like this:

...
  def getReferences(numberOfRefs: Int): List[reference] = {
    @tailrec
    def fetchReferences(numberOfRefs: Int, acc: List[reference]): List[reference] = {
      if (numberOfRefs <= 0) acc
      else {
        val batchSize = Math.min(numberOfRefs, refGeneratorLimit)
        fetchReferences(numberOfRefs - batchSize, acc ++ sendRequest(batchSize))
      }
    }

    fetchReferences(numberOfRefs, Nil)
  }

  private def sendRequest(numberOfRefs: Int): List[reference] = {
    val response = client.send(basicRequest.get(uri"$refGeneratorUrl/$environment/counter?numberofrefs=$numberOfRefs"))

    try {
      response.body match {
        case Left(body) =>
          val message = "Failed to get references from reference generator api"
          logger.error(s"${response.code} $message:\n$body")
          throw new HttpResponseException(response.code.code, message)
        case Right(body) =>
          val references = parse(body).getOrElse(null)
          val listOfReferences = references.as[List[reference]].getOrElse(null)
          logger.info(s"2xx response to GET:\n$listOfReferences")
          listOfReferences
      }
    } finally {
      client.close()
    }
  }
...

[thanhz]

This is much cleaner. I've made the changes.

[TomJKing]

Looks good. Thanks