Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest da-terraform-modules, tdr-terraform-modules, domain = "vpc" #561

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ian-hoyle
Copy link
Contributor

@ian-hoyle ian-hoyle commented Dec 19, 2024

Replaced vpc = true with domain = "vpc"
The domain argument is the current way to specify that the Elastic IP is for use in a VPC.
overwrite attribute has been removed to remove warnings

@ian-hoyle ian-hoyle changed the title use latest da-terraform-modules, tdr-terraform-modules, vpc=true is n… use latest da-terraform-modules, tdr-terraform-modules, domain = "vpc" Dec 19, 2024
Copy link
Contributor

@TomJKing TomJKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@ian-hoyle ian-hoyle merged commit e2948da into master Dec 19, 2024
2 checks passed
@ian-hoyle ian-hoyle deleted the vpc-warning-latest-tdr-da-terrafrom-modules branch December 19, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants