Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDRD-22 - Add "condition" to the trust polices #574

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

TDRD-22 - Add "condition" to the trust polices #574

wants to merge 7 commits into from

Conversation

vimleshtna
Copy link
Contributor

@vimleshtna vimleshtna commented Jan 13, 2025 •
edited
Loading

TomJKing
TomJKing reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@TomJKing TomJKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. One very minor comment.

Would suggest testing this before merging to main, by doing an apply from the branch, so can roll back if necessary.

modules/database-migrations/templates/migration_lambda.json.tpl Outdated
"StringEquals": {
"AWS:SourceAccount": "${account_id}"
}
}
}
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing line break at end of file

TomJKing
TomJKing previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@TomJKing TomJKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomJKing TomJKing TomJKing left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vimleshtna @TomJKing