TDR 3598: Refactor consignment_export_task_policy template to accept array of kms arns rather than single string
#275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t array of kms arns rather than single string
TomJKing
previously approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Looks good. Thanks
Just to note this is a breaking change until the calling Terraform is updated to send in an array. Therefore make sure this PR is approved and ready to be approved, before merging this change: nationalarchives/tdr-terraform-environments#413.
…xport bucket key)
…larchives/tdr-terraform-modules into feat-TDR-3598-pass-kms-arn-array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.