CLOP-10: Remove GuardDuty IPSets and update to templatefile #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomJKing
reviewed
Jun 20, 2024
guardduty/providers.tf
Outdated
| required_providers { | ||
| aws = ">= 5.0.0" | ||
| } | ||
| } |
There was a problem hiding this comment.
Add line break at end of file
There was a problem hiding this comment.
updated
ian-hoyle
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: to get a successful Terraform plan in the sandbox environment, I had to manually edit the state file to remove all references to GuardDuty IPSets (trying to use a remove block didn't work).
After updating the state file, I had to delete the DynamoDB lock due to a conflict in the hash value, reinitialise Terraform and do another Terraform plan.