TDRD-302/303 - Add new env variable for metadata review templates #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomJKing
reviewed
Aug 1, 2024
| @@ -97,6 +105,26 @@ data "aws_ssm_parameter" "gov_uk_transfer_complete_template_id" { | |||
| name = "/${local.environment}/gov_uk_notify/transfer_complete_template_id" | |||
| } | |||
|
|
|||
| data "aws_ssm_parameter" "gov_uk_metadata_review_tb_template_id" { | |||
There was a problem hiding this comment.
Do we need multiple different templates, rather than using a single template and pass in params into it to construct the correct message.
There was a problem hiding this comment.
The email templates are quite different from one another so I'm not sure how we would do that. You can see the templates I've created here https://www.notifications.service.gov.uk/services/47204260-cc6b-4814-ad27-ec83bec97003/templates/all
There was a problem hiding this comment.
OK. I'm just a bit concerned about long term maintenance of templates.
TomJKing
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following environment variables:
METADATA_REVIEW_REQUESTED_TB_TEMPLATE_ID-> Template that is sent to Transferring body user when metadata review requestedMETADATA_REVIEW_REQUESTED_DTA_TEMPLATE_ID-> Template that is sent to DTA reviewer when user requests metadata reviewMETADATA_REVIEW_REJECTED_TEMPLATE_ID-> Template sent to TB user when metadata is rejectedMETADATA_REVIEW_APPROVED_TEMPLATE_ID-> Template sent to TB user when metadata is approved