Merge pull request #3797 from nationalarchives/fix-draft-metadata-che…

…cks-page Use correct 'id' value to unhide success banner
nationalarchives · Mar 20, 2024 · 585de04 · 585de04
2 parents 8d4c23a + 619e069
commit 585de04
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/npm/src/checks/index.ts b/npm/src/checks/index.ts
@@ -46,7 +46,7 @@ export class Checks {
         )
         if (checksCompleted) {
           clearInterval(intervalId)
-          displayChecksCompletedBanner("draft-metadata-check")
+          displayChecksCompletedBanner("draft-metadata-checks")
         }
       } else {
         clearInterval(intervalId)

diff --git a/npm/test/update-check-progress.test.ts b/npm/test/update-check-progress.test.ts
@@ -137,8 +137,8 @@ test("'updateFileCheckProgress' shows a standard user, the notification banner a
 })
 
 test("'updateDraftMetadataValidationProgress' shows a standard user, the notification banner and an enabled continue button if all checks are 'completed'", async () => {
-  document.body.innerHTML = `<div id="draft-metadata-check-completed-banner" hidden></div>
-                            <a id="draft-metadata-check-continue" class="govuk-button--disabled" disabled></a>`
+  document.body.innerHTML = `<div id="draft-metadata-checks-completed-banner" hidden></div>
+                            <a id="draft-metadata-checks-continue" class="govuk-button--disabled" disabled></a>`
   const consignmentId = "e25438db-4bfb-41c9-8fff-6f2e4cca6421"
   mockGetCheckProgress.getConsignmentId.mockImplementation(
       () => consignmentId
@@ -160,8 +160,8 @@ test("'updateDraftMetadataValidationProgress' shows a standard user, the notific
 })
 
 test("'updateDraftMetadataValidationProgress' shows a standard user, the notification banner and an enabled continue button if all checks are 'completedWithIssues'", async () => {
-  document.body.innerHTML = `<div id="draft-metadata-check-completed-banner" hidden></div>
-                            <a id="draft-metadata-check-continue" class="govuk-button--disabled" disabled></a>`
+  document.body.innerHTML = `<div id="draft-metadata-checks-completed-banner" hidden></div>
+                            <a id="draft-metadata-checks-continue" class="govuk-button--disabled" disabled></a>`
   const consignmentId = "e25438db-4bfb-41c9-8fff-6f2e4cca6421"
   mockGetCheckProgress.getConsignmentId.mockImplementation(
       () => consignmentId