Skip to content

Commit

Permalink
More pagination examples, tweak dark theme colours (#42)
Browse files Browse the repository at this point in the history
* More pagination examples, tweak dark theme colours

* Push all changes to Chromatic on PR

* Add header outline in high contrast mode

* Adjust high contrast dark mode background

* Fix spacing classes in example

* Fix spacing classes in example
  • Loading branch information
ahosgood authored Oct 27, 2023
1 parent 30de430 commit b39502f
Show file tree
Hide file tree
Showing 6 changed files with 398 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ jobs:
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
storybookBuildDir: storybook
exitZeroOnChanges: true
onlyChanged: true
onlyChanged: false
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Tweaked dark theme colours
- `tna-visually-hidden` could instead use the class `tna-!--visually-hidden` (will deprecate one of these in the future)
- Changed Node version from `lts/hydrogen` to `lts/iron`
- Update the `spacing` and `spacing-mobile` functions in `spacing` to `space` and `space-mobile`
Expand Down
39 changes: 37 additions & 2 deletions src/nationalarchives/components/header/header.scss
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,10 @@
}
}

&--accent {
@include colour.accent;
}

@include media.on-larger-than-mobile {
.tna-header__navigation-toggle {
display: none;
Expand Down Expand Up @@ -508,7 +512,38 @@
}
}

&--accent {
@include colour.accent;
@include colour.on-high-contrast {
position: relative;

&::after {
position: absolute;
inset: auto 0 0;
z-index: 1;

@include colour.colour-border("keyline-dark", 1px, solid, bottom);

content: "";
}

&__navigation {
position: relative;
z-index: 2;
}

@include media.on-larger-than-mobile {
&__navigation-item-link {
border: 1px transparent solid;
border-bottom: none;

&:hover,
&--selected {
&,
&:link,
&:visited {
@include colour.colour-border("keyline-dark");
}
}
}
}
}
}
Loading

0 comments on commit b39502f

Please sign in to comment.