Skip to content

Commit

Permalink
Tweaks and fixes from v0.2.1 (#151)
Browse files Browse the repository at this point in the history
* Allow the arrows to appear on card heading links, fix padding on cards

* Remove whitespace from warning component

* Remove visited link colour from heading links with tna-link--no-visited-state

* Update CHANGELOG.md
  • Loading branch information
ahosgood authored Jul 19, 2024
1 parent 04eab1a commit db9b6a2
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 9 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added
### Changed

- Allowed the arrows to appear on card heading links

### Deprecated
### Removed
### Fixed

- Arrow colour for visited heading links with the class `tna-link--no-visited-state`
- Incorrect padding on the bottom of horizontal cards
- Removed space between heading and exclamation mark on warning components

### Security

## [0.2.1](https://github.com/nationalarchives/tna-frontend/compare/v0.2.0...v0.2.1) - 2024-07-19
Expand Down
7 changes: 1 addition & 6 deletions src/nationalarchives/components/card/card.scss
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,14 @@
&--horizontal.tna-background-tint &__inner,
&--horizontal.tna-background-accent &__inner {
padding-right: spacing.space(1);
padding-bottom: spacing.space(2);
padding-left: spacing.space(1);
}

&__heading {
order: 2;
}

&__heading-link {
&::after {
display: none !important;
}
}

&--full-click &__heading-link {
&::before {
content: "";
Expand Down
3 changes: 1 addition & 2 deletions src/nationalarchives/components/warning/template.njk
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
{%- set classes = containerClasses | join(' ') -%}
<div class="tna-warning{% if classes %} {{ classes }}{% endif %}"{% for attribute, value in params.attributes %} {{ attribute }}{% if value !== '' %}="{{ value }}"{% endif %}{% endfor %}>
<h{{ params.headingLevel }} class="tna-warning__heading">
<span class="tna-visually-hidden">{{ params.heading or 'Important information' }}</span>
<span class="tna-warning__heading-icon" aria-hidden="true">!</span>
<span class="tna-visually-hidden">{{ params.heading or 'Important information' }}</span><span class="tna-warning__heading-icon" aria-hidden="true">!</span>
</h{{ params.headingLevel }}>
<div class="tna-warning__body">
{{ params.body | safe }}
Expand Down
2 changes: 1 addition & 1 deletion src/nationalarchives/utilities/typography/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ small {
@include colour.colour-border("link", 0.125em, solid, right);
}

&:visited {
&:not(.tna-link--no-visited-state):visited {
&::after {
@include colour.colour-border("link-visited");
}
Expand Down

0 comments on commit db9b6a2

Please sign in to comment.