Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles and stories for the event card #10

Closed
wants to merge 1 commit into from
Closed

Conversation

helenb
Copy link

@helenb helenb commented Oct 3, 2023

This adds the new styles and stories needed for the event card.

  • It adds a new card in the story book list called event
  • It adds a new variant for laying out the card at desktop so the image fills one third - 'card--horizontal-thirds'
  • Adds overrides to existing card styles for the event card
  • Adds 'highlight', 'event type' and 'event descriptor' fields
  • Adds dark mode variations for the event card

@helenb helenb requested a review from ahosgood as a code owner October 3, 2023 09:47
@helenb
Copy link
Author

helenb commented Oct 3, 2023

@ahosgood here are my code changes for the event card - it seems to be failing a lot of tests which I suspect are fixtures files needing updating. I will have a look at this later as I want to focus now on getting this into ds-wagtail. However feel free to review these changes and assess if you think they would be useful.

@helenb
Copy link
Author

helenb commented Oct 17, 2023

@ahosgood would you like me to update this now that a few things have been refactored on the ds-wagtail side? If not it might be best just to close this now.

@ahosgood
Copy link
Member

@helenb - I think it might be best to just keep it all in ds-wagtail for now. If it helps you to develop using Storybook then carry on but I don't think we should merge it in to here until everything is finalised.

@ahosgood ahosgood closed this Jan 26, 2024
@ahosgood ahosgood deleted the feature/event-card branch January 26, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants