Revert 94286c087cbef2c36c8abdd3eb6e0d537d02f777 #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts 94286c0 which introduced an under the covers change of user intent from single entry multi filters into a single filter, this was done to force the filter subject based consumer create to be used. Problem is no other client does this so whatever backward compatible hopes there is or security gains just isn't realised and its just an unintended foot gun now Signed-off-by: R.I.Pienaar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts 94286c0 which introduced an under the covers change of user intent from single entry multi filters into a single filter, this was done to force the filter subject based consumer create to be used.
Problem is no other client does this so whatever backward compatible hopes there is or security gains just isn't realised and its just an unintended foot gun now