feat: Prevent deletes in consumers and streams #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcibrao-form3
force-pushed
the
dc-feat-deletable-resource
branch
3 times, most recently
from
3e4e803
to
38a3517
Compare
danielcibrao-form3
changed the title
danielcibrao-form3
force-pushed
the
dc-feat-deletable-resource
branch
3 times, most recently
from
967a702
to
33a94a9
Compare
Adding a `preventDelete` property for streams and consumers CRDS which when set to true nack should be able to delete it, otherwise it should just ignore that stream or consumer. The use case for this is in a multi-cloud context when we have deploy deployed in different clouds it becomes troublesome. For example, nack on GKE might check that a stream CRD is missing and proceeds to delete it, however that CRD exists in AWS and AKS and it should not be deleted because its going to impact other applications.
danielcibrao-form3
force-pushed
the
dc-feat-deletable-resource
branch
from
33a94a9
to
d1e9710
Compare
|
Managed Resource Deletion has historically been handled in Finalizers in Operators, but in NACK is being handled in a list/clean loop that was implemented in #56 I have opened #90 to try to figure out if we should go back to a Finalizer approach for resource deletion If we used finalizers, then only a Deleted CRD Finalizer would be able to delete a Managed NATS Stream or Consumer, so you wouldn't get any ghost deletes from a missing CRD |
caleblloyd
suggested changes
Oct 26, 2022
caleblloyd
reviewed
Oct 27, 2022
There was a problem hiding this comment.
I updated the descriptions, I think this looks good now. Would like to get @wallyqs opinion on it too though
caleblloyd
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
preventDeleteproperty for streams and consumers which when falsenack should be able to delete it, otherwise it should just ignore that
stream or consumer.
The use case for this is in a multi-cloud context when we have deploy
deployed in different clouds it becomes troublesome. For example, nack
on GKE might check that a stream CRD is missing and proceeds to delete
it, however that CRD exists in AWS and AKS and it should not be deleted
because its going to impact other applications.