Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] WatchFiltered method on KV #1739

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[ADDED] WatchFiltered method on KV #1739

merged 1 commit into from
Nov 21, 2024

Conversation

piotrpio
Copy link
Collaborator

This adds a WatchFiltered() method to both kv implementations (legacy and in jetstream package).

This PR is a prerequisite to finishing #1711

Signed-off-by: Piotr Piotrowski [email protected]

@piotrpio
[ADDED] WatchFiltered method on KV
0caf0c9 
Signed-off-by: Piotr Piotrowski <[email protected]>
@piotrpio piotrpio requested a review from Jarema November 19, 2024 22:38
@coveralls
Copy link

Coverage Status

coverage: 84.901% (+0.04%) from 84.861%
when pulling 0caf0c9 on watch-filtered
into 4530ef6 on main.

Jarema
Jarema approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit e963b77 into main Nov 21, 2024
6 checks passed
@piotrpio piotrpio deleted the watch-filtered branch November 21, 2024 09:55
@piotrpio piotrpio mentioned this pull request Nov 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrpio @coveralls @Jarema