Service / Simplification Documentation and Release Prep #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scottf
commented
Aug 17, 2023
•
scottf
commented
- Documented Service Framework
- Removed experimental tags from Service and Simplification
- Fixed test flappers
scottf
changed the title
arondi
reviewed
Aug 17, 2023
| @@ -459,39 +459,39 @@ public List<String> getChanges(ConsumerConfiguration serverCc) { | |||
| ConsumerConfigurationComparer serverCcc = new ConsumerConfigurationComparer(serverCc); | |||
| List<String> changes = new ArrayList<>(); | |||
|
|
|||
| if (deliverPolicy != null && deliverPolicy != serverCcc.getDeliverPolicy()) { changes.add("deliverPolicy"); }; | |||
There was a problem hiding this comment.
Extra semi-colons unnecessary, good to remove.
arondi
reviewed
Aug 17, 2023
| @@ -75,10 +75,10 @@ public static String validateConsumerName(String s, boolean required) { | |||
| public static String validatePrefixOrDomain(String s, String label, boolean required) { | |||
| return _validate(s, required, label, () -> { | |||
| if (s.startsWith(DOT)) { | |||
| throw new IllegalArgumentException(label + " cannot start with `.` [" + s + "]"); | |||
There was a problem hiding this comment.
Thanks for fixing to quote from tic
arondi
reviewed
Aug 17, 2023
| public Discovery(Connection conn) { | ||
| this(conn, -1, -1); | ||
| this(conn, 0, 0); |
There was a problem hiding this comment.
Makes more sense based on the comparison for < 1
arondi
reviewed
Aug 17, 2023
| { | ||
| //Ignore | ||
| } | ||
| Thread.sleep(250); // should get more pings |
arondi
reviewed
Aug 17, 2023
| @@ -159,12 +159,12 @@ public void testServiceWorkflow() throws Exception { | |||
| InfoResponse infoResponse2 = service2.getInfoResponse(); | |||
| StatsResponse statsResponse1 = service1.getStatsResponse(); | |||
| StatsResponse statsResponse2 = service2.getStatsResponse(); | |||
| EndpointResponse[] endpointResponseArray1 = new EndpointResponse[]{ | |||
| EndpointStats[] endpointStatsArray1 = new EndpointStats[]{ | |||
There was a problem hiding this comment.
Good naming change to match
arondi
reviewed
Aug 17, 2023
| public byte[] getData() { | ||
| return message.getData(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Glad to get rid of these unnecessary methods. Makes it clearer/simpler to use/understand.
arondi
reviewed
Aug 17, 2023
| */ | ||
| public class EndpointResponse implements JsonSerializable { | ||
| public class EndpointStats implements JsonSerializable { |
arondi
approved these changes
Aug 17, 2023
…nd simplification
…nd simplification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.