Add StatisticsCollector to Options for custom statistics tracking #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnlcox
force-pushed
the
statistics-collector
branch
from
efee3c0
to
3e5e2c6
Compare
johnlcox
force-pushed
the
statistics-collector
branch
from
3e5e2c6
to
7bc524b
Compare
johnlcox
commented
Sep 5, 2023
| } | ||
| else { | ||
| statistics.incrementOrphanRepliesReceived(); | ||
| if (advancedTracking) { |
There was a problem hiding this comment.
Previously, all orphan counter was being incremented for every duplicate or orphan when advancedTracking was not enabled. Does this change to first check the advancedTracking flag and only when enabled increment duplicate or orphan replies.
There was a problem hiding this comment.
Yeah, this is some weird original code, and I'm to blame, sigh. This change is good.
scottf
approved these changes
Sep 6, 2023
| } | ||
| else { | ||
| statistics.incrementOrphanRepliesReceived(); | ||
| if (advancedTracking) { |
There was a problem hiding this comment.
Yeah, this is some weird original code, and I'm to blame, sigh. This change is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an interface for statistics collection that can be set on
Optionsto allow for custom metric collection (e.g. to prometheus).This fixes #960