feat(core,node,deno): added a check on the connect function that the client wasn't given a ws/s:// url as these are difficult issues to diagnose
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aricart
force-pushed
the
fix-123
branch
3 times, most recently
from
ca64bfd to
764695b
Compare
aricart
added a commit
that referenced
this pull request
Nov 9, 2024
…client wasn't given a ws/s:// url as these are difficult issues to diagnose #129 Signed-off-by: Alberto Ricart <[email protected]>
aricart
force-pushed
the
fix-123
branch
2 times, most recently
from
ef54ad0 to
4bc5156
Compare
…client wasn't given a ws/s:// url as these are difficult issues to diagnose Signed-off-by: Alberto Ricart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #123