Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requestMany - JitterTimer is now called 'stall' and RequestStrategy is type alias to simple strings. #152

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Nov 21, 2024

change(core): requestMany() JitterTimer and its associated jitter property is now called "stall"
change(core): requestMany() RequestStrategy is now a simple string "timer" | "count" | "stall" | "sentinel"

Signed-off-by: Alberto Ricart [email protected]

…roperty is now called "stall"

change(core): requestMany() `RequestStrategy` is now a simple string "timer" | "count" | "stall" | "sentinel"

Signed-off-by: Alberto Ricart <[email protected]>
…roperty is now called "stall"

change(core): requestMany() `RequestStrategy` is now a simple string "timer" | "count" | "stall" | "sentinel"

Signed-off-by: Alberto Ricart <[email protected]>
@aricart aricart force-pushed the request-many branch 2 times, most recently from 45ac710 to 460055d Compare November 21, 2024 00:18
…roperty is now called "stall"

change(core): requestMany() `RequestStrategy` is now a simple string "timer" | "count" | "stall" | "sentinel"

Signed-off-by: Alberto Ricart <[email protected]>
Copy link

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 3ced2f5 into main Nov 21, 2024
20 checks passed
@aricart aricart deleted the request-many branch November 21, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants