Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added deliver_group to consumer config #366

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Added deliver_group to consumer config #366

merged 1 commit into from
Jan 30, 2024
+44 −0

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Jan 30, 2024 •
edited
Loading

Added the missing property for deliver_group.

Note: ConsumerConfig was generated from this schema I believe, which doesn't have deliver_group defined https://github.com/nats-io/jsm.go/blob/main/schemas/jetstream/api/v1/consumer_create_request.json#L140

@mtmk mtmk linked an issue Jan 30, 2024 that may be closed by this pull request
Missing DeliverGroup property from ConsumerConfig #365
Closed
@mtmk mtmk requested review from caleblloyd and Jarema January 30, 2024 15:23
caleblloyd
caleblloyd approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 9b049d6 into main Jan 30, 2024
10 checks passed
@mtmk mtmk deleted the 365-deliver-group-consumer-config branch January 30, 2024 17:41
mtmk added a commit that referenced this pull request Feb 2, 2024
@mtmk
Release 2.1.0-preview.6
0999202 
* Send buffer changes (#346)
* Added deliver_group to consumer config (#366)
* Ping command as value task source (#358)
@mtmk mtmk mentioned this pull request Feb 2, 2024
Merged
mtmk added a commit that referenced this pull request Feb 2, 2024
@mtmk
Release 2.1.0-preview.6 (#369)
667b77e 
* Send buffer changes (#346)
* Added deliver_group to consumer config (#366)
* Ping command as value task source (#358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleblloyd caleblloyd caleblloyd approved these changes

@Jarema Jarema Awaiting requested review from Jarema

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing DeliverGroup property from ConsumerConfig
2 participants
@mtmk @caleblloyd