KV never set duplicate window #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtmk
reviewed
Jul 24, 2024
| @@ -226,13 +226,8 @@ private static StreamConfig CreateStreamConfig(NatsKVConfig config) | |||
| // MirrorDirect = | |||
| // Mirror = | |||
| Retention = StreamConfigRetention.Limits, // from ADR-8 | |||
| DuplicateWindow = config.MaxAge != default ? config.MaxAge : TimeSpan.FromMinutes(2), // 120_000_000_000ns, from ADR-8 | |||
There was a problem hiding this comment.
just to note bug was that when MaxAge was set to something like 30 minutes, DumplicateWindow was always set to the same value and that was creating a wrong config on the server. by letting the server decide we're avoiding any checks here. if we wanted to duplicate what Go client is doing, we could set DuplicateWindow to 2min here (avoiding the MaxAge check) and leave the check below. but I think this is a better solution. less complexity.
Merged
mtmk
added a commit
that referenced
this pull request
Jul 24, 2024
mtmk
added a commit
that referenced
this pull request
Aug 2, 2024
* Handle various protocol errors and socket exceptions (#584) * Fetch idle timeout default fix (#582) * Obj store empty list fixed (#578) * KV never set duplicate window (#577) * Resolved issue of ObjStore GetInfo MTime returning 0 (#567) * Add logging enhancements and improve error handling (#570) * Base64 Encoding simplification + optimization (#549) * Use string.Create when building a new inbox string (#551)
Merged
mtmk
added a commit
that referenced
this pull request
Aug 2, 2024
* Handle various protocol errors and socket exceptions (#584) * Fetch idle timeout default fix (#582) * Obj store empty list fixed (#578) * KV never set duplicate window (#577) * Resolved issue of ObjStore GetInfo MTime returning 0 (#567) * Add logging enhancements and improve error handling (#570) * Base64 Encoding simplification + optimization (#549) * Use string.Create when building a new inbox string (#551)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.