Make Transport.connect a classmethod #389
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a number of places where we expect methods to be called in a specific order. It mostly concerns
connect
methods that are expected to be called as soon as the class is instantiated. You can find places like this by looking forassert self._something
statements at the beginning of methods.One such place is
Transport
which doesn't work ifTransport.connect
is not called first. The PR convertsTransport.connect
into a classmethod. So, now it's a constructor that returns an instantiated and connectedTransport
. It guarantees that anyTransport
instance is always connected. Well, or disconnected, but at least we can guarantee thatTcpTransport._io_reader
is neverNone
.