Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rtt to Client #914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add rtt to Client #914

wants to merge 1 commit into from

Conversation

n1ghtmare
Copy link
Collaborator

Closes: #909

@n1ghtmare n1ghtmare self-assigned this Apr 5, 2023
Jarema
Jarema requested changes Apr 5, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except error type.

async-nats/src/lib.rs Outdated Show resolved Hide resolved
Jarema
Jarema requested changes Apr 5, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change needed.

This does not return RTT, as it does not await PONG.

@n1ghtmare n1ghtmare marked this pull request as draft April 5, 2023 19:31
@n1ghtmare n1ghtmare force-pushed the n1ghtmare/rtt-for-client branch 2 times, most recently from 42a515e to 2e97188 Compare April 7, 2023 21:38
@n1ghtmare n1ghtmare marked this pull request as ready for review April 7, 2023 22:02
@n1ghtmare n1ghtmare force-pushed the n1ghtmare/rtt-for-client branch 3 times, most recently from de827b8 to 357741e Compare April 10, 2023 13:05
@caspervonb caspervonb marked this pull request as draft April 10, 2023 16:50
@n1ghtmare n1ghtmare requested a review from Jarema April 10, 2023 17:26
@n1ghtmare n1ghtmare force-pushed the n1ghtmare/rtt-for-client branch 3 times, most recently from 33bccae to 6275f28 Compare April 11, 2023 22:53
caspervonb
caspervonb requested changes Apr 12, 2023
View reviewed changes
async-nats/src/lib.rs Outdated Show resolved Hide resolved
async-nats/src/lib.rs Outdated Show resolved Hide resolved
async-nats/src/lib.rs Outdated Show resolved Hide resolved
async-nats/src/lib.rs Outdated Show resolved Hide resolved
async-nats/src/lib.rs Outdated Show resolved Hide resolved
async-nats/src/lib.rs Outdated Show resolved Hide resolved
@n1ghtmare n1ghtmare force-pushed the n1ghtmare/rtt-for-client branch 3 times, most recently from b1e5a5d to 00b98c1 Compare April 13, 2023 20:52
@n1ghtmare n1ghtmare marked this pull request as ready for review April 14, 2023 20:52
@n1ghtmare n1ghtmare force-pushed the n1ghtmare/rtt-for-client branch 2 times, most recently from 97f9721 to 85121a7 Compare May 30, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Awaiting requested review from Jarema

@caspervonb caspervonb Awaiting requested review from caspervonb

Requested changes must be addressed to merge this pull request.

Assignees

@n1ghtmare n1ghtmare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Client::rtt for async_nats
3 participants
@n1ghtmare @caspervonb @Jarema