Value to healthz metric, avoid ignoring server when error #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver. Added value to healthz metric with error or "ok". Added test to this
|
I completely agree, I hope this PR will be merged as soon as possible |
ddbmajor
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
PR to this #237
I added value to healthz metric, I think its helpfull, easy to view whats going on.
It looks like this:
gnatsd_healthz_status{server_id="http://localhost:8222",value="Get \"http://localhost:8222/healthz\": dial tcp [::1]:8222: connectex: No connection could be made because the target machine actively refused it."} 1When error
gnatsd_healthz_status{server_id="http://localhost:8222",value="ok"} 0When ok
I avoid skipping server when its down because its alert situation from my point of view.