fix: [#287] fix semgrep linter errors

.cspell.json

@@ -55,6 +55,7 @@
     "ncipollo",
     "noproxy",
     "noreply",
+    "nosemgrep",
     "nuxt",
     "oidc",
     "Oidc",

.github/workflows/test.yml

@@ -146,6 +146,7 @@ jobs:
           # Import test GPG key
           # secretlint-disable
           {
+            # nosemgrep
             echo -e "-----BEGIN PGP PRIVATE KEY BLOCK-----\n"
             cat __tests__/fixtures/test-key-committer.pgp
             echo -e "\n-----END PGP PRIVATE KEY BLOCK-----\n"

.semgrepignore

@@ -0,0 +1,3 @@
+cinder/
+dist/
+megalinter-reports/

__tests__/unit/queue.test.ts

@@ -240,6 +240,7 @@ describe('Queue', () => {
 
     const output = gitLogForLatestCommit(gitRepo.getDirPath())
 
+    // nosemgrep
     expect(RegExp(`gpg:.+RSA.+${signingKeyFingerprint}`).test(output)).toBe(
       true
     )

src/__tests__/config.ts

@@ -32,6 +32,7 @@ export function testConfiguration(): TestConfig {
   )
 
   // secretlint-disable
+  // nosemgrep
   const gpgPrivateKey = `-----BEGIN PGP PRIVATE KEY BLOCK-----\n\n${gpgPrivateKeyBody}\n-----END PGP PRIVATE KEY BLOCK-----`
   // secretlint-enable
 

src/__tests__/gpg.ts

@@ -102,6 +102,7 @@ export const overwriteAgentConfiguration = async (
   config: string,
   homedir: string
 ): Promise<void> => {
+  // nosemgrep
   const gpgAgentConfPath: string = path.join(homedir, 'gpg-agent.conf')
 
   fs.writeFile(gpgAgentConfPath, config, function (err) {

src/git-repo-dir.ts

@@ -10,13 +10,14 @@ export class GitRepoDir {
     this.dirPath = this.normalizePath(dirPath)
   }
 
-  guardThatDirExists(dirPath): void {
+  guardThatDirExists(dirPath: string): void {
     if (!existsSync(dirPath)) {
       throw new GitDirNotFoundError(dirPath)
     }
   }
 
-  normalizePath(dirPath): string {
+  normalizePath(dirPath: string): string {
+    // nosemgrep
     return isAbsolute(dirPath) ? dirPath : resolve(dirPath)
   }
 

src/queue-name.ts

@@ -20,7 +20,8 @@ export class QueueName implements Nullable {
     return this.value === other.value
   }
 
-  guardThatNameIsValid(value): void {
+  guardThatNameIsValid(value: string): void {
+    // nosemgrep
     if (!RegExp(`^[a-z-_ ]{1,${MAX_QUEUE_NAME_LENGTH}}$`).test(value)) {
       throw new QueueNameNotValidError(value)
     }