Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Secure Git Guide to SvelteKit #72

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

grmbyrn
Copy link
Contributor

@grmbyrn grmbyrn commented Nov 21, 2023

Issue #68

Remove the old version. Make secure-git-guide-branch the root folder. Update README with info on how to run SvelteKit. Replace old version of linters and gitignore with secure-git-guide-branch's.

… Update README with info on how to run SvelteKit. Replace old version linters and gitignore with secure-git-guide-branch's.
@josecelano josecelano linked an issue Nov 21, 2023 that may be closed by this pull request
@josecelano josecelano self-requested a review November 21, 2023 17:07
@josecelano
Copy link
Member

Hi @grmbyrn I think we should:

  • Add the folder site to .gitignore.
  • Remove the current MegaLinter configuration: .mega-linter.yml, ...
  • Remove mkdocs configuration: mkdocs.yml
  • Remove both workflows: deploy-documentation.yml and mega-linter.yml

I think the repo should contain only:

  • The new version you did.
  • Updated README

I mean, since we are going to install MegaLinter from scratch we should not add any config now. And we have to remove the deploy workflow because we are not using mkdocs anymore.

After merging the new clean basic version we will:

@grmbyrn
Copy link
Contributor Author

grmbyrn commented Nov 21, 2023

Ok, so I will remove everything from this except what was in the SvelteKit folder and the READ.ME? What do you mean by add site to .gitignore? Is this in the repo?

@josecelano
Copy link
Member

Ok, so I will remove everything from this except what was in the SvelteKit folder and the READ.ME? What do you mean by add site to .gitignore? Is this in the repo?

I had a folder site in the root folder and I thought it was generated when you run npm run build. But the new version is using /.svelte-kit and it's already included in the .gitignore file so we do not include it in the repo.

@grmbyrn
Copy link
Contributor Author

grmbyrn commented Nov 21, 2023

Okay, I have removed MegaLinter, mkdocs configuration, and both workflows. I also corrected the READ.ME header image's relative path to prevent the image from breaking.

@josecelano
Copy link
Member

ACK 86b7ff3

@josecelano josecelano merged commit f6eab3e into nautilus-cyberneering:main Nov 22, 2023
@grmbyrn grmbyrn deleted the secure-git-guide-2 branch November 27, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Secure Git Guide to Svelet.Kit
2 participants