New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Node IDs in dependent steps & run response middleware on partial success #216

Merged

JohnStarich merged 3 commits into master from bugfix/resolve-successful-nodes

Aug 21, 2024

Member

JohnStarich commented Aug 21, 2024 •

edited

Loading

Add failing test for partial success with unresolved Node IDs
Resolve Node IDs in dependent steps, even on partial successes
Add failing test for partial success not scrubbing unrequested fields from response
Fix builtin middleware not running on partial success

Fixes #214

JohnStarich added 3 commits

August 21, 2024 17:10


          Add failing test for partial success with unresolved Node IDs

af7b294


          Fix builtin middleware not running on partial success

4532b50


          Resolve Node IDs in dependent steps, even on partial successes

e547bb4

JohnStarich merged commit 0ac544a into master

6 of 7 checks passed

JohnStarich deleted the bugfix/resolve-successful-nodes branch

August 21, 2024 22:15

Member Author

JohnStarich commented Aug 21, 2024

Cutting a new minor release (v0.4.0) since existing implementations may assume the response middleware does not run on errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet