-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the template to deploy extra objects #471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor things that happened to notice.
Please update the helm docs though to get the new stuff and pass the CI
@@ -1197,6 +1197,19 @@ | |||
} | |||
}, | |||
"description": "List of Nautobot objects (matching the Nautobot spec) to create deployments for" | |||
}, | |||
"extraObjects": { | |||
"type": "array", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add description
key as we have in the other ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: #462
This PR allows you to deploy additional Kubernetes manifests. These manifests can be defined in the
extraObjects
list. The following snippet shows an example: