Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When Nautobot Notes Are Implemented, Changes May Be Needed #190

Closed
jvanderaa opened this issue Jul 3, 2022 · 4 comments · Fixed by #324
Closed

When Nautobot Notes Are Implemented, Changes May Be Needed #190

jvanderaa opened this issue Jul 3, 2022 · 4 comments · Fixed by #324
Assignees
@chadell
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Milestone
1.0.0

Comments

@jvanderaa
Copy link
Collaborator

Environment

  • Current

Proposed Functionality

Noticed that we have "Notes" as part of the current model. It looks like a global implementation may be upcoming. If this is implemented in Nautobot, we should remove/change the naming to avoid confusion - nautobot/nautobot#1984

Use Case

Prevent confusion of models
@chadell
Copy link
Contributor

chadell commented Jul 4, 2022

Totally, this was the first thought I got when I saw the new notes feature for Nautobot 1.4.
I think that there is too much duplication, so I would tend to remove the plugin one.

@chadell chadell added the type: housekeeping Changes to the application which do not directly impact the end user label Jul 4, 2022
@scetron
Copy link
Contributor

scetron commented Aug 16, 2022

Agreed, will investigate this soon as 1.4 was released today on 16 Aug. `22

@chadell chadell added this to the 1.0.0 milestone Sep 29, 2022
@glennmatthews
Copy link
Contributor

This also causes some warnings during startup of Nautobot 2.0 with this app installed:

 ?: (drf_spectacular.W001) /opt/nautobot/.local/lib/python3.11/site-packages/nautobot_circuit_maintenance/api/serializers.py: Warning [MaintenanceNoteTaskView > NoteSerializer]: Encountered 2 components with identical names "Note" and different classes <class 'nautobot_circuit_maintenance.api.serializers.NoteSerializer'> and <class 'nautobot.extras.api.serializers.NoteSerializer'>. This will very likely result in an incorrect schema. Try renaming one.
 ?: (drf_spectacular.W001) /opt/nautobot/.local/lib/python3.11/site-packages/nautobot_circuit_maintenance/api/serializers.py: Warning [MaintenanceNoteTaskView > NoteSerializer]: Encountered 2 components with identical names "NoteRequest" and different classes <class 'nautobot_circuit_maintenance.api.serializers.NoteSerializer'> and <class 'nautobot.extras.api.serializers.NoteSerializer'>. This will very likely result in an incorrect schema. Try renaming one.
 ?: (drf_spectacular.W001) /opt/nautobot/.local/lib/python3.11/site-packages/nautobot_circuit_maintenance/api/serializers.py: Warning [MaintenanceNoteTaskView > NoteSerializer]: Encountered 2 components with identical names "PatchedNoteRequest" and different classes <class 'nautobot_circuit_maintenance.api.serializers.NoteSerializer'> and <class 'nautobot.extras.api.serializers.NoteSerializer'>. This will very likely result in an incorrect schema. Try renaming one.
 ?: (drf_spectacular.W001) /opt/nautobot/.local/lib/python3.11/site-packages/nautobot_circuit_maintenance/api/views.py: Warning [MaintenanceNoteTaskView]: Encountered 2 components with identical names "PaginatedNoteList" and different classes <class 'nautobot_circuit_maintenance.api.serializers.NoteSerializer'> and <class 'nautobot.extras.api.serializers.NoteSerializer'>. This will very likely result in an incorrect schema. Try renaming one.

itdependsnetworks pushed a commit to itdependsnetworks/nautobot-app-circuit-maintenance that referenced this issue Apr 3, 2024
@unpapillon
Update Telstra.py for new notification format (nautobot#190)
d302083 
* Update Telstra.py for new notification format

* rename variables

* Update telstra.py

* add new telstra test files

* Update test_e2e for telstra

* Update test_parser for Telstra

* fix linting for telstra parser

* update regex condition

* fix useless import

* fix mypy lint

* keep new arelion instead of Telia

* fix indent

* fix pylint

* fix docstyle

* add good result.json

* fix json results

* fix test_e2e

* fix Telstra tests

* fix compatibility with old format

* fix parser organisation

* fix maintenance details

* fix black linting

* add summary to tests

* unit test fixing

* improve telsrtra parser and complete tests

* all test validated

---------

Co-authored-by: c.radet <[email protected]>
@chadell chadell self-assigned this Sep 13, 2024
@gsnider2195 gsnider2195 linked a pull request Sep 19, 2024 that will close this issue
refactor: 🚧 Replace custom Notes by Nautobot ones #324
Merged
@chadell
Copy link
Contributor

chadell commented Oct 15, 2024

fixed in #324

@chadell chadell closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chadell chadell

Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

refactor: 🚧 Replace custom Notes by Nautobot ones nautobot/nautobot-app-circuit-maintenance
4 participants
@glennmatthews @scetron @chadell @jvanderaa