refactor: 🚧 Replace custom Notes by Nautobot ones #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadell
requested review from
glennmatthews,
pke11y and
scetron
as code owners
gsnider2195
reviewed
Sep 25, 2024
|
Some of these files still need to be formatted with ruff: https://github.com/nautobot/nautobot-app-circuit-maintenance/actions/runs/11048959517/job/30693493079?pr=324 The pull request CI is currently failing silently |
gsnider2195
reviewed
Sep 26, 2024
gsnider2195
reviewed
Sep 26, 2024
| ObjectChangeLogView.as_view(), | ||
| name="circuitmaintenance_changelog", | ||
| kwargs={"model": CircuitMaintenance}, | ||
| "circuit-maintenances/overview/", views.CircuitMaintenanceOverview.as_view(), name="circuitmaintenance_overview" |
There was a problem hiding this comment.
Possibly migrate this view into a custom action on CircuitMaintenanceUIViewSet as well? Not blocking for this PR though.
Co-authored-by: Glenn Matthews <[email protected]>
glennmatthews
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.