fix loading and saving bugs with vlans, lags and vrfs #310
+231
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav-C
changed the title
Dav-C
requested review from
glennmatthews,
chadell,
susanhooks,
jeffkala and
scetron
as code owners
susanhooks
approved these changes
Jan 31, 2025
scetron
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #311
What's Changed
Fix bug when loading vlans
Fix bug with untagged vlan to interface assignments
Fix bug with lag to interface assignments
Fix bug with vrf to interface assignments
Add additional error handling for methods assigning objects to interfaces
Refactor methods assigning objects to interfaces to all use the same pattern