Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get linters and unit tests passing as a baseline #213

Merged
merged 7 commits into from
Jul 1, 2024
Merged

Get linters and unit tests passing as a baseline #213

merged 7 commits into from
Jul 1, 2024

Conversation

glennmatthews
Copy link
Contributor

  • Add .gitignore for compiled docs files
  • Remove deprecated version keyword from docker-compose files
  • Fix bad links in docs
  • Black, pylint, yamllint fixes
  • Don't try to run dolt both locally and as a hosted service by default.

@glennmatthews glennmatthews changed the title Get linters passing Get linters and unit tests passing as a baseline Jul 1, 2024
HanlinMiao
HanlinMiao approved these changes Jul 1, 2024
View reviewed changes
Copy link

@HanlinMiao HanlinMiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glennmatthews glennmatthews merged commit 50df6b2 into develop Jul 1, 2024
15 checks passed
@glennmatthews glennmatthews deleted the u/glennmatthews-fixes-1 branch July 1, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HanlinMiao HanlinMiao HanlinMiao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glennmatthews @HanlinMiao