Rebake from latest cookie, fix mark_safe usage #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template:
```
{
"template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
"dir": "nautobot-app",
"ref": "develop",
"path": null
}
```
Cookie:
```
{
"remote": "[email protected]:nautobot/nautobot-app-version-control.git",
"path": "/Users/glennmatthews/Documents/git-stuff/nautobot-app-version-control",
"repository_path": "/Users/glennmatthews/Documents/git-stuff/nautobot-app-version-control",
"dir": "",
"branch_prefix": "drift-manager",
"context": {
"codeowner_github_usernames": "@smith-ntc",
"full_name": "Network to Code, LLC",
"email": "[email protected]",
"github_org": "nautobot",
"app_name": "nautobot_version_control",
"verbose_name": "Nautobot Version Control",
"app_slug": "nautobot-version-control",
"project_slug": "nautobot-app-version-control",
"repo_url": "https://github.com/nautobot/nautobot-app-version-control",
"base_url": "version-control",
"min_nautobot_version": "2.0.3",
"max_nautobot_version": "2.9999",
"camel_name": "NautobotVersionControl",
"project_short_description": "Nautobot Version Control with Dolt",
"model_class_name": "None",
"open_source_license": "Apache-2.0",
"docs_base_url": "https://docs.nautobot.com",
"docs_app_url": "https://docs.nautobot.com/projects/version-control/en/latest",
"_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
"_output_dir": "/Users/glennmatthews/Documents/git-stuff",
"_repo_dir": "/Users/glennmatthews/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
"_checkout": "develop"
},
"base_branch": "develop",
"remote_name": "origin",
"pull_request_strategy": "PullRequestStrategy.CREATE",
"post_actions": [
"PostAction.BLACK"
],
"baked_commit_ref": "e400b7359a805402f1ec49a9555424e6bfce3856",
"draft": true
}
```
CLI Arguments:
```
{
"cookie_dir": "",
"input": false,
"json_filename": "",
"output_dir": "",
"push": false,
"template": "",
"template_dir": "",
"template_ref": "",
"pull_request": null,
"post_action": [],
"disable_post_actions": false,
"draft": null
}
```
smk4664
approved these changes
Jul 2, 2024
timizuoebideri1
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebake from latest cookie. Updated
ruffconfigs correctly warned about a bunch of places we were unsafely usingmark_safe, which I've updated in this PR to useformat_htmlinstead where appropriate.Lots of other ruff warnings about raw SQL calls and potential SQL injection which are currently beyond the scope of this PR to address, but I've tried to make sure they at least have TODO comments for later revisitation.