drop python 3.8 (#176)

* drop python 3.8

* don't support py3.12 yet due to issues with testing

* add support for py3.12

.github/workflows/ci.yml

@@ -14,7 +14,7 @@ jobs:
       - name: "Set up Python"
         uses: "actions/setup-python@v2"
         with:
-          python-version: "3.11"
+          python-version: "3.12"
       - name: "Install Python Packages for Linting"
         run: "pip install --upgrade pip wheel invoke toml black"
       - name: "Linting: Black"
@@ -29,7 +29,7 @@ jobs:
       - name: "Set up Python"
         uses: "actions/setup-python@v2"
         with:
-          python-version: "3.11"
+          python-version: "3.12"
       - name: "Install Python Packages for Linting"
         run: "pip install --upgrade pip wheel invoke toml bandit"
       - name: "Linting: Bandit"
@@ -46,7 +46,7 @@ jobs:
       - name: "Set up Python"
         uses: "actions/setup-python@v2"
         with:
-          python-version: "3.11"
+          python-version: "3.12"
       - name: "Install Python Packages for Linting"
         run: "pip install --upgrade pip wheel invoke toml pydocstyle"
       - name: "Linting: pydocstyle"
@@ -63,7 +63,7 @@ jobs:
       - name: "Set up Python"
         uses: "actions/setup-python@v2"
         with:
-          python-version: "3.11"
+          python-version: "3.12"
       - name: "Install Python Packages for Linting"
         run: "pip install --upgrade pip wheel invoke toml flake8"
       - name: "Linting: flake8"
@@ -80,7 +80,7 @@ jobs:
       - name: "Set up Python"
         uses: "actions/setup-python@v2"
         with:
-          python-version: "3.11"
+          python-version: "3.12"
       - name: "Install Python Packages for Linting"
         run: "pip install --upgrade pip wheel invoke toml yamllint"
       - name: "Linting: yamllint"
@@ -95,7 +95,7 @@ jobs:
       - name: "Set up Python"
         uses: "actions/setup-python@v2"
         with:
-          python-version: "3.11"
+          python-version: "3.12"
       - name: "Install Python Packages for Setup"
         run: "pip install invoke poetry toml"
       - name: "Build Container"
@@ -113,7 +113,7 @@ jobs:
       - name: "Set up Python"
         uses: "actions/setup-python@v2"
         with:
-          python-version: "3.11"
+          python-version: "3.12"
       - name: "Install Python Packages for Linting"
         run: "pip install invoke poetry toml"
       - name: "Build Container"
@@ -126,7 +126,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
     runs-on: "ubuntu-20.04"
     env:
       PYTHON_VER: "${{ matrix.python-version }}"
@@ -136,7 +136,7 @@ jobs:
       - name: "Set up Python"
         uses: "actions/setup-python@v2"
         with:
-          python-version: "3.11"
+          python-version: "3.12"
       - name: "Install Python Packages for Linting"
         run: "pip install invoke poetry toml"
       - name: "Build Container"
@@ -155,7 +155,7 @@ jobs:
       - name: "Set up Python"
         uses: "actions/setup-python@v2"
         with:
-          python-version: "3.11"
+          python-version: "3.12"
       - name: "Install Python Packages for Linting"
         run: "pip install invoke poetry toml"
       - name: "Set env"
@@ -184,7 +184,7 @@ jobs:
       - name: "Set up Python"
         uses: "actions/setup-python@v2"
         with:
-          python-version: "3.11"
+          python-version: "3.12"
       - name: "Install Python Packages"
         run: "pip install poetry"
       - name: "Set env"

docs/dev/CONTRIBUTING.md

@@ -10,7 +10,7 @@ This section describes how to install *nornir_nautobot* for development, how to
 
 ## Python Versions
 
-This leverages Python3.8 or later. All features will be tested against 3.8 - 3.11 versions of Python.
+This leverages Python3.9 or later. All features will be tested against 3.9 - 3.12 versions of Python.
 
 ## Versioning
 

nornir_nautobot/plugins/inventory/nautobot.py

@@ -55,7 +55,7 @@ def _set_host(data: Dict[str, Any], name: str, groups, host, defaults: Defaults)
 class NautobotInventory:  # pylint: disable=R0902
     """Nautobot Nornir Inventory."""
 
-    def __init__(  # pylint: disable=R0913
+    def __init__(  # pylint: disable=R0913,too-many-positional-arguments
         self,
         nautobot_url: Union[str, None],
         nautobot_token: Union[str, None],

nornir_nautobot/plugins/tasks/dispatcher/default.py

@@ -95,7 +95,7 @@ def check_connectivity(cls, task: Task, logger, obj) -> Result:
         return Result(host=task.host)
 
     @classmethod
-    def compliance_config(
+    def compliance_config(  # pylint: disable=too-many-positional-arguments
         cls,
         task: Task,
         logger,
@@ -138,7 +138,7 @@ def compliance_config(
         return Result(host=task.host, result={"feature_data": feature_data})
 
     @classmethod
-    def generate_config(
+    def generate_config(  # pylint: disable=too-many-positional-arguments,too-many-locals
         cls,
         task: Task,
         logger,
@@ -149,7 +149,6 @@ def generate_config(
         jinja_filters: Optional[dict] = None,
         jinja_env: Optional[jinja2.Environment] = None,
     ) -> Result:
-        # pylint: disable=too-many-locals
         """A small wrapper around template_file Nornir task.
 
         Args:
@@ -255,7 +254,7 @@ class NapalmDefault(DispatcherMixin):
     """Default collection of Nornir Tasks based on Napalm."""
 
     @classmethod
-    def get_config(
+    def get_config(  # pylint: disable=too-many-positional-arguments
         cls,
         task: Task,
         logger,
@@ -427,7 +426,7 @@ class NetmikoDefault(DispatcherMixin):
     config_command = "show run"
 
     @classmethod
-    def get_config(
+    def get_config(  # pylint: disable=too-many-positional-arguments
         cls,
         task: Task,
         logger,

nornir_nautobot/plugins/tasks/dispatcher/mikrotik_routeros.py

@@ -43,7 +43,7 @@ class ApiMikrotikRouteros(DispatcherMixin):
     ]
 
     @classmethod
-    def get_config(  # pylint: disable=R0913,R0914
+    def get_config(  # pylint: disable=R0913,R0914,too-many-positional-arguments
         cls, task: Task, logger, obj, backup_file: str, remove_lines: list, substitute_lines: list
     ) -> Result:
         """Get the latest configuration from the device.
@@ -116,7 +116,7 @@ class NetmikoMikrotikRouteros(NetmikoDefault):
     version_command = "system resource print"
 
     @classmethod
-    def get_config(  # pylint: disable=R0913,R0914
+    def get_config(  # pylint: disable=R0913,R0914,too-many-positional-arguments
         cls, task: Task, logger, obj, backup_file: str, remove_lines: list, substitute_lines: list
     ) -> Result:
         """Get the latest configuration from the device using Netmiko. Overrides default get_config.

nornir_nautobot/plugins/tasks/dispatcher/ruckus_smartzone.py

@@ -77,7 +77,7 @@ def _api_auth(cls, obj, logger, session_params: tuple) -> dict:
         return service_ticket
 
     @classmethod
-    def _build_urls(  # pylint: disable=too-many-arguments,too-many-locals
+    def _build_urls(  # pylint: disable=too-many-arguments,too-many-locals,too-many-positional-arguments
         cls,
         obj,
         logger,
@@ -138,7 +138,7 @@ async def _async_get_data(cls, url_dict: dict) -> dict:
         return api_data
 
     @classmethod
-    def get_config(  # pylint: disable=R0913,R0914
+    def get_config(  # pylint: disable=too-many-arguments,too-many-locals,too-many-positional-arguments
         cls, task: Task, logger, obj, backup_file: str, remove_lines: list, substitute_lines: list
     ) -> Result:
         """Get the latest configuration from the device.