update with review feedback

navapbc · Aug 13, 2024 · 4ab4dc2 · 4ab4dc2
1 parent e45969b
commit 4ab4dc2
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/api/tests/src/task/opportunities/test_export_opportunity_data_task.py b/api/tests/src/task/opportunities/test_export_opportunity_data_task.py
@@ -50,19 +50,20 @@ def test_export_opportunity_data_task(
             ]
         )
 
+        expected_opportunity_ids = set([opp.opportunity_id for opp in opportunities])
         # Verify csv file contents
         with file_util.open_stream(export_opportunity_data_task.csv_file, "r") as infile:
             reader = csv.DictReader(infile)
-            assert set([opp.opportunity_id for opp in opportunities]) == set(
+            assert expected_opportunity_ids == set(
                 [int(record["opportunity_id"]) for record in reader]
             )
 
+        # Verify JSON file contents
         with file_util.open_stream(export_opportunity_data_task.json_file, "r") as infile:
             # Parse JSON File
-            print("JSON OPPORTUNITIES:")
             json_opportunities = json.load(infile)
 
-            assert set([opp.opportunity_id for opp in opportunities]) == set(
+            assert expected_opportunity_ids == set(
                 [int(record["opportunity_id"]) for record in json_opportunities["opportunities"]]
             )