[Issue #95]: change newsletter to subscribe terminology #111
Conversation
github-actions
bot
added
documentation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 83.87% | 879/1048 |
| 🟡 | Branches | 68.25% | 230/337 |
| 🟡 | Functions | 76.11% | 172/226 |
| 🟢 | Lines | 83.45% | 827/991 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟡 | ... / page.tsx |
75% | 100% | 50% | 75% |
| 🟢 | ... / SubscribeForm.tsx |
93.75% | 78.57% | 87.5% | 93.62% |
| 🟡 | ... / page.tsx |
71.43% | 100% | 50% | 71.43% |
| 🟡 | ... / page.tsx |
71.43% | 100% | 50% | 71.43% |
Test suite run success
175 tests passing in 57 suites.
Report generated by 🧪jest coverage report action from a361861
| page_title: "Newsletter | Simpler.Grants.gov", | ||
| title: "Newsletter signup", | ||
| title: "Subscribe to project updates", | ||
| intro: "Subscribe to get Simpler.Grants.gov project updates in your inbox!", | ||
| paragraph_1: | ||
| "If you sign up for the Simpler.Grants.gov newsletter, we’ll keep you informed of our progress and you’ll know about every opportunity to get involved.", |
There was a problem hiding this comment.
Could you change this to "If you sign up for the Simpler.Grants.gov project updates, we'll keep you..." ? Replacing the word "newsletter."
There was a problem hiding this comment.
good catch - here's the update:
There was a problem hiding this comment.
Note that the title of pages still shows Newsletter
There was a problem hiding this comment.
Oh, good catch! we'll want to change that! I realize this is different than subscribe and @andycochran and @crystabelrangel may have different thoughts on this, but could we change that to say "Mailing List"? We can always change it something else if Design thinks it's better as a different name.
There was a problem hiding this comment.
"Project Updates"? Not sure if that is too redundant.
|
Closing for now, we might pick this up later. |
Summary
Fixes #95
Time to review: 15 min
Changes proposed
subscribe/newsletter/confirmation=>/subscribe/confirmation/newsletter/unsubscribe=>/unsubscribe(top level route)Screen.Recording.2024-06-27.at.12.22.17.PM.mov