This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Issue #167] Fix search page string translation #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btabaska
changed the title
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 90.06% (+0.15% 🔼) |
707/785 |
| 🟡 | Branches | 71.08% (-0.1% 🔻) |
204/287 |
| 🟢 | Functions | 86.31% | 145/168 |
| 🟢 | Lines | 90.75% (+0.15% 🔼) |
667/735 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / SearchResultsHeader.tsx |
90.91% (+2.02% 🔼) |
50% (-10% 🔻) |
100% | 100% |
Test suite run success
154 tests passing in 47 suites.
Report generated by 🧪jest coverage report action from 840c3bb
acouch
approved these changes
Aug 8, 2024
andycochran
approved these changes
Aug 8, 2024
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
Fixes HHS#2042 Updated most search strings on Search page to use correct next-intl translation components Added strings to Messages file Updated the unit tests as well because they were not inheriting context due to improper import path from non-global context source <img width="1583" alt="Screenshot 2024-08-07 at 1 36 18 PM" src="https://github.com/user-attachments/assets/1b613d26-cbd0-4d0e-b831-0380c6f72af6">
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
Fixes HHS#2042 Updated most search strings on Search page to use correct next-intl translation components Added strings to Messages file Updated the unit tests as well because they were not inheriting context due to improper import path from non-global context source <img width="1583" alt="Screenshot 2024-08-07 at 1 36 18 PM" src="https://github.com/user-attachments/assets/1b613d26-cbd0-4d0e-b831-0380c6f72af6">
acouch
pushed a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Sep 18, 2024
Fixes #2042 Updated most search strings on Search page to use correct next-intl translation components Added strings to Messages file Updated the unit tests as well because they were not inheriting context due to improper import path from non-global context source <img width="1583" alt="Screenshot 2024-08-07 at 1 36 18 PM" src="https://github.com/user-attachments/assets/1b613d26-cbd0-4d0e-b831-0380c6f72af6">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #167
Time to review: 5 mins
Changes proposed
Updated most search strings on Search page to use correct next-intl translation components
Added strings to Messages file
Context for reviewers
Updated the unit tests as well because they were not inheriting context due to improper import path from non-global context source
Additional information