This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Issue: #166] Create ecs task to export opportunity data as csv and json #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
reviewed
Aug 9, 2024
Rwolfe-Nava
changed the title
Rwolfe-Nava
changed the title
Rwolfe-Nava
commented
Aug 9, 2024
| @@ -58,7 +58,7 @@ def _process_assistance_listing(assistance_listings: list[dict]) -> str: | |||
| ) | |||
|
|
|||
|
|
|||
| def opportunity_to_csv(opportunities: Sequence[dict]) -> io.StringIO: | |||
| def opportunities_to_csv(opportunities: Sequence[dict], output: io.StringIO) -> None: | |||
There was a problem hiding this comment.
Note: I renamed this function with a plural name because I thought it would be slightly more accurate, since it can handle more than one opportunity by taking in a sequence.
Rwolfe-Nava
changed the title
Rwolfe-Nava
force-pushed
the
rwolfe-nava/166-create-ecs-task-for-opportunity-data-csv-and-json
branch
from
9d9a47c to
e45969b
Compare
chouinar
reviewed
Aug 12, 2024
api/tests/src/task/opportunities/test_export_opportunity_data_task.py
Outdated
Show resolved
Hide resolved
api/tests/src/task/opportunities/test_export_opportunity_data_task.py
Outdated
Show resolved
Hide resolved
api/tests/src/task/opportunities/test_export_opportunity_data_task.py
Outdated
Show resolved
Hide resolved
chouinar
approved these changes
Aug 14, 2024
api/tests/src/task/opportunities/test_export_opportunity_data_task.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Chouinard <[email protected]>
chouinar
approved these changes
Aug 15, 2024
Rwolfe-Nava
deleted the
rwolfe-nava/166-create-ecs-task-for-opportunity-data-csv-and-json
branch
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
…son (#176) Fixes #166 - Adds export_opportunity_data task - Changes opportunity_to_csv function to opportunities_to_csv to be more flexible by including output as a parameter - Adds unit test for export_opportunity_data task. - The test runs the export_opportunity_data task, uploading a csv and json file to mock_s3_bucket. Then it reads the files and verifies contents. --------- Co-authored-by: Michael Chouinard <[email protected]>
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
…son (#176) Fixes #166 - Adds export_opportunity_data task - Changes opportunity_to_csv function to opportunities_to_csv to be more flexible by including output as a parameter - Adds unit test for export_opportunity_data task. - The test runs the export_opportunity_data task, uploading a csv and json file to mock_s3_bucket. Then it reads the files and verifies contents. --------- Co-authored-by: Michael Chouinard <[email protected]>
acouch
pushed a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Sep 18, 2024
…son (navapbc#176) Fixes #166 - Adds export_opportunity_data task - Changes opportunity_to_csv function to opportunities_to_csv to be more flexible by including output as a parameter - Adds unit test for export_opportunity_data task. - The test runs the export_opportunity_data task, uploading a csv and json file to mock_s3_bucket. Then it reads the files and verifies contents. --------- Co-authored-by: Michael Chouinard <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #166
Time to review: 20 mins
Changes proposed
Context for reviewers