Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

[Issue #181]Add no console log to eslint rules #182

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

btabaska
Copy link
Collaborator

Summary

Fixes #181

Time to review: 1 mins

Changes proposed

Added new rule to eslint to prevent leaving behind console log statements

Context for reviewers

normal expected rule in eslint configurations

Copy link

Coverage report for ./frontend

St.
Category Percentage Covered / Total
🟢 Statements 90.06% 707/785
🟡 Branches 71.33% 204/286
🟢 Functions 86.31% 145/168
🟢 Lines 90.75% 667/735

Test suite run success

155 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from b46d149

Copy link
Member

@acouch acouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally:

console.log = = error

image

console.war = = all good

image

@btabaska btabaska merged commit 7f7103d into main Aug 28, 2024
12 checks passed
@btabaska btabaska deleted the btabaska/181-no-console-eslint branch August 28, 2024 17:45
acouch pushed a commit that referenced this pull request Sep 18, 2024
Fixes HHS#2037

> Added new rule to eslint to prevent leaving behind console log
statements

> normal expected rule in eslint configurations
acouch pushed a commit that referenced this pull request Sep 18, 2024
Fixes HHS#2037

> Added new rule to eslint to prevent leaving behind console log
statements

> normal expected rule in eslint configurations
acouch pushed a commit to HHS/simpler-grants-gov that referenced this pull request Sep 18, 2024
Fixes #2037

> Added new rule to eslint to prevent leaving behind console log
statements

> normal expected rule in eslint configurations
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add no-console to Eslint Rules
2 participants