This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Issue #37]: finish e2e tests #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 84.14% | 870/1034 |
| 🟡 | Branches | 65.01% | 223/343 |
| 🟡 | Functions | 75.58% | 164/217 |
| 🟢 | Lines | 84.18% | 809/961 |
Test suite run success
164 tests passing in 56 suites.
Report generated by 🧪jest coverage report action from 98dca62
acouch
approved these changes
May 20, 2024
There was a problem hiding this comment.
@rylew1 tested locally, looks great.
(suggestion): The e23 tests now require the API to work, so we could update the docs in a separate ticket or just knock it out here: https://github.com/navapbc/simpler-grants-gov/blob/main/frontend/README.md#-end-to-end-e2e-testing
|
@acouch - updated docs - will need a reapproval |
github-actions
bot
added
the
documentation
rylew1
commented
May 22, 2024
| @@ -144,7 +144,9 @@ To run E2E tests using VS Code: | |||
| 1. Download the VS Code extension described in these [Playwright docs](https://playwright.dev/docs/running-tests#run-tests-in-vs-code) | |||
| 2. Follow the [instructions](https://playwright.dev/docs/getting-started-vscode#running-tests) Playwright provides | |||
|
|
|||
| In CI, the "Front-end Checks" workflow (`.github/workflows/ci-frontend.yml`) summary will include an "Artifacts" section where there is an attached "playwright-report". [Playwright docs](https://playwright.dev/docs/ci-intro#html-report) describe how to view HTML Report in more detail. | |||
| Playwright E2E tests run "local-to-local", requiring both the frontend and the API to be running for the tests to pass - and for the database to be seeded with data. | |||
There was a problem hiding this comment.
this is the only new change after approval
There was a problem hiding this comment.
I was thinking of adding to the instructions:
+ - `cd ../api && make init db-seed-local start` (prerequisite to start the API)
- `npx playwright install --with-deps`There was a problem hiding this comment.
Oh I saw the approval and merged very quickly - can open a small follow on
acouch
approved these changes
May 22, 2024
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
acouch
pushed a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Sep 18, 2024
Fixes #2082 - add some of the relevant tests from bug bash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #37
Time to review: 10 min
Changes proposed
to run just search tests locally in ui:
npm run test:e2e:ui -- tests/e2e/search/search.spec.tsScreen.Recording.2024-05-16.at.3.47.31.PM.mov