[Issue #40]: Setup pa11y-ci #41
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 83.27% | 846/1016 |
| 🟡 | Branches | 68.31% | 222/325 |
| 🟡 | Functions | 75.46% | 163/216 |
| 🟢 | Lines | 82.81% | 795/960 |
Test suite run success
168 tests passing in 54 suites.
Report generated by 🧪jest coverage report action from 2cdebec
|
@andycochran @acouch - this is ready for review |
There was a problem hiding this comment.
Are these changes intended to be included in this pa11y ticket?
| }, | ||
| { | ||
| "url": "http://localhost:3000/search?status=forecasted,posted", | ||
| "viewport": { "width": 320, "height": 480 }, |
There was a problem hiding this comment.
If we are going to set viewport to width 320 and height 480 on all components we can just set that as a default and then change on the few components where we don't want that behavior
| ] | ||
| }, | ||
| { | ||
| "url": "http://localhost:3000", |
There was a problem hiding this comment.
Unsure of why we are duplicating each url twice with truncated actions in the bottom one. Is this to take different actions on the second iteration of the URL?
| jobs: | ||
| build: | ||
| name: Pa11y-ci tests | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
if we are running this locally, we may want to have it set to a matrix of OS' like the example pa11y tests show. Since locally we would be running on macOS-latest.
name: test (${{ matrix.os }}, node ${{ matrix.node-version }})
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version: [18, 20]
Fixes #2077 - Add `pa11y-ci` to run PR checks - Tests for each of the pages we have so far
Summary
Fixes #40
Time to review: 5 min
Changes proposed
pa11y-cito run PR checksFuture work:
Have pa11y run on a proper sitemap - other project types (like jekyll) are able to do this - [Task]: Have pa11y ci run against a dynamic sitemap #73
Load up the API with data so the search page will have opportunity results - [Task]: Add a pa11y ci step to spin up the API so it shows search results #74
Remove the color contrast ignore when we rebrand the site
Possibly have it comment on the PR with results of the axe run