This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Issue #51]: debounce pagination #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 83.27% | 846/1016 |
| 🟡 | Branches | 68.31% | 222/325 |
| 🟡 | Functions | 75.46% | 163/216 |
| 🟢 | Lines | 82.81% | 795/960 |
Test suite run success
168 tests passing in 54 suites.
Report generated by 🧪jest coverage report action from 19cd99d
andycochran
reviewed
May 28, 2024
| @@ -31,6 +33,10 @@ export default function SearchPagination({ | |||
| }: SearchPaginationProps) { | |||
| const { pending } = useFormStatus(); | |||
|
|
|||
| const debouncedHandlePageChange = useDebouncedCallback((newPage: number) => { | |||
| handlePageChange(newPage); | |||
| }, DEBOUNCE_TIME); | |||
There was a problem hiding this comment.
(just curious) Does this mean there will always be a 500 delay? Even on the first click?
There was a problem hiding this comment.
Basically yes - I wanted to have a quick meeting also - that's why this is still in draft.
I also would need to update some of the e2e tests to wait for page change
There was a problem hiding this comment.
Sounds good. Let's meet to talk it thru. There might be a different UX we could use — e.g. instead of debouncing, disable the pagination while results are loading.
andycochran
approved these changes
May 28, 2024
andycochran
approved these changes
Jun 3, 2024
andycochran
approved these changes
Jun 3, 2024
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
acouch
pushed a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Sep 18, 2024
Fixes #2074 - Add 300ms debounce on pagination
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #51
Time to review: 3 min
Changes proposed
Screen.Recording.2024-05-24.at.5.12.51.PM.mov