This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Issue 56]: Date rounding bug #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 83.27% (+0.02% 🔼) |
846/1016 |
| 🟡 | Branches | 68.31% | 222/325 |
| 🟡 | Functions | 75.46% | 163/216 |
| 🟢 | Lines | 82.81% (+0.02% 🔼) |
795/960 |
Test suite run success
168 tests passing in 54 suites.
Report generated by 🧪jest coverage report action from 706dd8d
rylew1
commented
May 29, 2024
|
|
||
| // Create a new Date object using the local time | ||
| const date = new Date(year, month - 1, day); | ||
|
|
||
| const options: Intl.DateTimeFormatOptions = { | ||
| year: "numeric", | ||
| month: "long", |
There was a problem hiding this comment.
this is the format date function we call from SearchResultListItem - it needs to be updated to be called from the local time instead of just the UTC time (which is I think what happens when you just do new Date(dateStr)
There was a problem hiding this comment.
This subtracts 1 from the month?
There was a problem hiding this comment.
The month is just 0-based - you can open chrome console and try it by enter 3 for the month - you'll see it's April:
There was a problem hiding this comment.
@andycochran I think it's ready for review now
andycochran
approved these changes
May 30, 2024
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
Fixes #56 - Update the date creation to the parsed year/month/day so it creates the `Date` object using the local time - this may prevent any type of rounding - Add some tests to ensure the right dates are showing up on search
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
Fixes #56 - Update the date creation to the parsed year/month/day so it creates the `Date` object using the local time - this may prevent any type of rounding - Add some tests to ensure the right dates are showing up on search
acouch
pushed a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Sep 18, 2024
Fixes #56 - Update the date creation to the parsed year/month/day so it creates the `Date` object using the local time - this may prevent any type of rounding - Add some tests to ensure the right dates are showing up on search
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #56
Time to review: 2 min
Changes proposed
Dateobject using the local time - this may prevent any type of rounding