This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Issue #58] Locally, preserve the auth token in the OpenAPI across refreshes #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylew1
reviewed
May 31, 2024
|
|
||
| # For the OpenAPI docs, set whether the auth tokens are stored | ||
| # across refreshes of the page. Currently we only set this to true locally | ||
| persist_authorization_openapi: bool = False |
There was a problem hiding this comment.
This just sets it false by default - and then the local.env overrides it locally?
There was a problem hiding this comment.
Yes - this way non-locally it is false. Followed this pattern for several fields and it works well.
rylew1
approved these changes
May 31, 2024
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
…ss refreshes (#67) Fixes HHS#2072 Set the `persistAuthorization` OpenAPI config locally to True For local development, we frequently need to go to http://localhost:8080/docs - enter the auth token, and then repeat this process every time we reopen this page or refresh. Having to either copy paste or retype in the auth token is tedious. This flag makes it so it gets preserved in your browsers local storage. We are only enabling this for the local endpoint at the moment as there are possibly security implications we would need to consider non-locally (eg. what if someone is using a public computer).
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
…ss refreshes (#67) Fixes HHS#2072 Set the `persistAuthorization` OpenAPI config locally to True For local development, we frequently need to go to http://localhost:8080/docs - enter the auth token, and then repeat this process every time we reopen this page or refresh. Having to either copy paste or retype in the auth token is tedious. This flag makes it so it gets preserved in your browsers local storage. We are only enabling this for the local endpoint at the moment as there are possibly security implications we would need to consider non-locally (eg. what if someone is using a public computer).
acouch
pushed a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Sep 18, 2024
…refreshes (navapbc#67) Fixes #2072 Set the `persistAuthorization` OpenAPI config locally to True For local development, we frequently need to go to http://localhost:8080/docs - enter the auth token, and then repeat this process every time we reopen this page or refresh. Having to either copy paste or retype in the auth token is tedious. This flag makes it so it gets preserved in your browsers local storage. We are only enabling this for the local endpoint at the moment as there are possibly security implications we would need to consider non-locally (eg. what if someone is using a public computer).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #58
Time to review: 3 mins
Changes proposed
Set the
persistAuthorizationOpenAPI config locally to TrueContext for reviewers
For local development, we frequently need to go to http://localhost:8080/docs - enter the auth token, and then repeat this process every time we reopen this page or refresh. Having to either copy paste or retype in the auth token is tedious. This flag makes it so it gets preserved in your browsers local storage.
We are only enabling this for the local endpoint at the moment as there are possibly security implications we would need to consider non-locally (eg. what if someone is using a public computer).