This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Issue #88] Adjust docker commands based on recent updates #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
requested review from
jamesbursa,
andycochran,
acouch and
aplybeah
as code owners
github-actions
bot
added
documentation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 83.27% | 846/1016 |
| 🟡 | Branches | 68.31% | 222/325 |
| 🟡 | Functions | 75.46% | 163/216 |
| 🟢 | Lines | 82.81% | 795/960 |
Test suite run success
168 tests passing in 54 suites.
Report generated by 🧪jest coverage report action from 137b56a
rylew1
approved these changes
Jun 17, 2024
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
Fixes HHS#2063 Remove the version field from the docker-compose files Adjust the docker commands to use `docker compose` instead of `docker-compose` A recent version of docker removed the need for specifying a version in the compose files - so the field is now obsolete and just gives a warning whenever you run a command: https://docs.docker.com/compose/compose-file/04-version-and-name/ The change in the command we run is actually from 2021 and makes sure we use docker compose v2. Depending on how you've setup your local instance of docker, `docker-compose` may have been aliased to `docker compose` anyways (I actually think if it wasn't, certain things break anyways). This is just using the proper format for certain. I went through running several docker commands and noticed no difference, as this change shouldn't meaningfully change anything, that is to be expected.
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
Fixes HHS#2063 Remove the version field from the docker-compose files Adjust the docker commands to use `docker compose` instead of `docker-compose` A recent version of docker removed the need for specifying a version in the compose files - so the field is now obsolete and just gives a warning whenever you run a command: https://docs.docker.com/compose/compose-file/04-version-and-name/ The change in the command we run is actually from 2021 and makes sure we use docker compose v2. Depending on how you've setup your local instance of docker, `docker-compose` may have been aliased to `docker compose` anyways (I actually think if it wasn't, certain things break anyways). This is just using the proper format for certain. I went through running several docker commands and noticed no difference, as this change shouldn't meaningfully change anything, that is to be expected.
acouch
pushed a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Sep 18, 2024
) Fixes #2063 Remove the version field from the docker-compose files Adjust the docker commands to use `docker compose` instead of `docker-compose` A recent version of docker removed the need for specifying a version in the compose files - so the field is now obsolete and just gives a warning whenever you run a command: https://docs.docker.com/compose/compose-file/04-version-and-name/ The change in the command we run is actually from 2021 and makes sure we use docker compose v2. Depending on how you've setup your local instance of docker, `docker-compose` may have been aliased to `docker compose` anyways (I actually think if it wasn't, certain things break anyways). This is just using the proper format for certain. I went through running several docker commands and noticed no difference, as this change shouldn't meaningfully change anything, that is to be expected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #88
Time to review: 5 mins
Changes proposed
Remove the version field from the docker-compose files
Adjust the docker commands to use
docker composeinstead ofdocker-composeContext for reviewers
A recent version of docker removed the need for specifying a version in the compose files - so the field is now obsolete and just gives a warning whenever you run a command:
https://docs.docker.com/compose/compose-file/04-version-and-name/
The change in the command we run is actually from 2021 and makes sure we use docker compose v2. Depending on how you've setup your local instance of docker,
docker-composemay have been aliased todocker composeanyways (I actually think if it wasn't, certain things break anyways). This is just using the proper format for certain.Additional information
I went through running several docker commands and noticed no difference, as this change shouldn't meaningfully change anything, that is to be expected.