This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Issue #96]: Opportunity listing page (first pass) #97
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| import { Metadata } from "next"; | ||
| import NotFound from "../../../not-found"; | ||
| import OpportunityListingAPI from "../../../api/OpportunityListingAPI"; | ||
| import { getTranslations } from "next-intl/server"; | ||
|
|
||
| export async function generateMetadata() { | ||
| const t = await getTranslations({ locale: "en" }); | ||
| const meta: Metadata = { | ||
| title: t("OpportunityListing.page_title"), | ||
| description: t("OpportunityListing.meta_description"), | ||
| }; | ||
| return meta; | ||
| } | ||
|
|
||
| export default async function OpportunityListing({ | ||
| params, | ||
| }: { | ||
| params: { id: string }; | ||
| }) { | ||
| const id = Number(params.id); | ||
|
|
||
| // Opportunity id needs to be a number greater than 1 | ||
| if (isNaN(id) || id < 0) { | ||
| return <NotFound />; | ||
| } | ||
|
|
||
| const api = new OpportunityListingAPI(); | ||
| let opportunity; | ||
| try { | ||
| opportunity = await api.getOpportunityById(id); | ||
| } catch (error) { | ||
| console.error("Failed to fetch opportunity:", error); | ||
| return <NotFound />; | ||
| } | ||
|
|
||
| if (!opportunity.data) { | ||
| return <NotFound />; | ||
| } | ||
|
|
||
| return ( | ||
| <div className="grid-container"> | ||
| <div className="grid-row margin-y-4"> | ||
| <div className="usa-table-container"> | ||
| <table className="usa-table usa-table--borderless margin-x-auto width-full maxw-desktop-lg"> | ||
| <thead> | ||
| <tr> | ||
| <th>Field Name</th> | ||
| <th>Data</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| {Object.entries(opportunity.data).map(([key, value]) => ( | ||
| <tr key={key}> | ||
| <td className="word-wrap">{key}</td> | ||
| <td className="word-wrap">{JSON.stringify(value)}</td> | ||
| </tr> | ||
| ))} | ||
| </tbody> | ||
| </table> | ||
|
There was a problem hiding this comment. Could you add a small bit of special logic for the summary field so that it doesn't print out as the full JSON, but instead pulls out each of the fields? Just to make it look a little bit nicer / make it look like we've done a lot more and are truly just waiting on shoving it into whatever designs. So, rather than for key, value in obj.items():
if key == "summary":
for summary_key, summary_value in value.items():
print(summary_key)
print(JSON.stringify(summary_value)
else:
print(key)
print(value)
There was a problem hiding this comment. Thanks @chouinar I added this:
|
||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import "server-only"; | ||
|
There was a problem hiding this comment. only ever run this code on the next server |
||
|
|
||
| import BaseApi from "./BaseApi"; | ||
|
|
||
| export default class OpportunityListingAPI extends BaseApi { | ||
| get basePath(): string { | ||
| return process.env.API_URL || ""; | ||
| } | ||
|
|
||
| get namespace(): string { | ||
| return "opportunities"; | ||
| } | ||
|
|
||
| async getOpportunityById(opportunityId: number) { | ||
| const subPath = `${opportunityId}`; | ||
| const response = await this.request( | ||
| "GET", | ||
| this.basePath, | ||
| this.namespace, | ||
| subPath, | ||
| ); | ||
| return response; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still catching up on whether or not making a page async affects ability to statically render the page. The opportunity pages are the same for everyone and rarely update so should not be rebuilt for every single request. Statically rendering seems like the easiest way to achieve that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can punt this consideration for #85 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧵 here https://nava.slack.com/archives/C057K146W8H/p1718912909890579