Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Remove whitespace in m4 files #348

Closed
wants to merge 1 commit into from

Conversation

ing-eoking
Copy link
Collaborator

🔗 Related Issue

⌨️ What I did

  • m4 file에서 whitespace를 제거합니다.

@ing-eoking
Copy link
Collaborator Author

@jhpark816

수정되었습니다.

@ing-eoking ing-eoking force-pushed the clean2 branch 2 times, most recently from 39f6d9c to b34d9a6 Compare January 24, 2025 08:58
@ing-eoking
Copy link
Collaborator Author

@jhpark816

코멘트 내용 올려주시면 감사하겠습니다;
우선 기억나는데로 수정했습니다.

Copy link
Contributor

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일부 리뷰



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 line 제거

@@ -35,7 +35,7 @@ AC_DEFUN([_PANDORA_SEARCH_SASL],[
HAVE_LIBSASL="$HAVE_LIBSASL2"
LIBSASL="$LIBSASL2"
LIBSASL_PREFIX="$LIBSASL2_PREFIX"
LTLIBSASL="$LT_LIBSASL2"
LTLIBSASL="$LT_LIBSASL2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위에 있는 코드 포함하여 재 확인 필요

AC_MSG_ERROR([Automake 1.5 or newer is required to use intltool])
;;
*)
;;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자체 확인 필요

}
' "$1/Makefile.in" >"$1/Makefile"]
rm -f "$1/Makefile.tmp"
mv "$1/stamp-it.tmp" "$1/stamp-it"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 재확인

PYTHON3_VERSION=""
AS_IF([test -z "$PYTHON3"],[
AC_MSG_ERROR([Cannot find python$PYTHON3_VERSION in your system path])
PYTHON3_VERSION=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 재확인

if test -z "$PYTHON3_CPPFLAGS"; then
python3_path=`$PYTHON3 -c "import distutils.sysconfig; \
print(distutils.sysconfig.get_python_inc());"`
if test -n "${python3_path}"; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위의 print 문장을 밀어주세요.

@jhpark816
Copy link
Contributor

@ing-eoking
확인하고 수정이 완료되면, noti 코멘트 주세요.

@ing-eoking ing-eoking force-pushed the clean2 branch 2 times, most recently from 348a56f to 2ddc13a Compare February 3, 2025 07:27
@ing-eoking
Copy link
Collaborator Author

@jhpark816

전체 수정되었습니다.

@ing-eoking ing-eoking marked this pull request as draft February 3, 2025 08:38
@ing-eoking
Copy link
Collaborator Author

위의 PR이 반영되었으므로 해당 PR 닫겠습니다.

@ing-eoking ing-eoking closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants