-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTERNAL: Remove whitespace in m4 files #348
Conversation
수정되었습니다. |
39f6d9c
to
b34d9a6
Compare
코멘트 내용 올려주시면 감사하겠습니다; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일부 리뷰
m4/pandora_have_libmysqlclient.m4
Outdated
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 line 제거
m4/pandora_have_sasl.m4
Outdated
@@ -35,7 +35,7 @@ AC_DEFUN([_PANDORA_SEARCH_SASL],[ | |||
HAVE_LIBSASL="$HAVE_LIBSASL2" | |||
LIBSASL="$LIBSASL2" | |||
LIBSASL_PREFIX="$LIBSASL2_PREFIX" | |||
LTLIBSASL="$LT_LIBSASL2" | |||
LTLIBSASL="$LT_LIBSASL2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
위에 있는 코드 포함하여 재 확인 필요
m4/pandora_intltool.m4
Outdated
AC_MSG_ERROR([Automake 1.5 or newer is required to use intltool]) | ||
;; | ||
*) | ||
;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
자체 확인 필요
} | ||
' "$1/Makefile.in" >"$1/Makefile"] | ||
rm -f "$1/Makefile.tmp" | ||
mv "$1/stamp-it.tmp" "$1/stamp-it" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 재확인
m4/pandora_python3_devel.m4
Outdated
PYTHON3_VERSION="" | ||
AS_IF([test -z "$PYTHON3"],[ | ||
AC_MSG_ERROR([Cannot find python$PYTHON3_VERSION in your system path]) | ||
PYTHON3_VERSION="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 재확인
if test -z "$PYTHON3_CPPFLAGS"; then | ||
python3_path=`$PYTHON3 -c "import distutils.sysconfig; \ | ||
print(distutils.sysconfig.get_python_inc());"` | ||
if test -n "${python3_path}"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
위의 print 문장을 밀어주세요.
@ing-eoking |
348a56f
to
2ddc13a
Compare
전체 수정되었습니다. |
위의 PR이 반영되었으므로 해당 PR 닫겠습니다. |
🔗 Related Issue
⌨️ What I did