Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Remove whitespace in libmemcached files #351

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ing-eoking
Copy link
Collaborator

🔗 Related Issue

⌨️ What I did

  • libmemcached의 소스코드 및 기타 파일에서의 whitespace를 제거합니다.

Copy link
Contributor

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

@@ -2575,7 +2575,7 @@ memcached_return_t memcached_coll_smget_response(memcached_server_write_instance
}

if (ptr->root->flags.binary_protocol == true) {
fprintf(stderr, "Binary protocols for the collection are not supported.\n");
fprintf(stderr, "Binary protocols for the collection are not supported.\n");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기는 tab을 2개 space로 변환하여 시작 위치를 맞추시죠.

@@ -211,43 +211,43 @@ const char *memcached_strerror(memcached_st *, memcached_return_t rc)
return "ATTR ERROR bad value";

case MEMCACHED_COUNT:
return "ITEMS COUNT";
return "ITEMS COUNT";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 tab이 2개 space로 변환하여 return 시작 위치를 일관되게 맞춥시다.

관련하여 수정된 코드를 모두 확인하고, 완료 되면 noti 주세요.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhpark816

전체 수정되었습니다.

@ing-eoking ing-eoking force-pushed the clean5 branch 2 times, most recently from 75b78f7 to 13acfb0 Compare January 24, 2025 03:12
@jhpark816 jhpark816 merged commit 225fe21 into naver:develop Jan 24, 2025
1 check passed
@ing-eoking ing-eoking deleted the clean5 branch January 24, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants