Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fjerner litt custom event handlere til fordel for react og react-focus-trap. #126

Merged
merged 7 commits into from
Oct 4, 2023

Conversation

peterbb
Copy link
Contributor

@peterbb peterbb commented Oct 4, 2023

Hver commit burde gi mening hver for seg. Highlights:

  • bruker onKeyDown-property direkte på elementer, i stede for å installere listener med useEffect
  • bruker react-focus-trap for å håndtere tabbing

Fikser også eksisterende bug. How to reproduce: lukk alle accordions (hovedenheter), tab blir "stuck" på krysset.

@peterbb peterbb requested a review from a team as a code owner October 4, 2023 08:20
@peterbb peterbb merged commit 35ac38a into master Oct 4, 2023
3 checks passed
@peterbb peterbb deleted the cleanup branch October 4, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants