Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
luantr committed Feb 12, 2025
1 parent f412209 commit 56300b8
Show file tree
Hide file tree
Showing 9 changed files with 39 additions and 51 deletions.
17 changes: 17 additions & 0 deletions .github/workflows/build-and-deploy.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Build & Deploy
on:
push:
workflow_dispatch:

jobs:
jar-app:
uses: navikt/teamesyfo-github-actions-workflows/.github/workflows/jar-app.yaml@main
permissions:
actions: read
contents: write
security-events: write
packages: write
id-token: write
secrets: inherit
with:
app: esyfovarsel
19 changes: 0 additions & 19 deletions .github/workflows/deploy-app.yml

This file was deleted.

7 changes: 2 additions & 5 deletions naiserator-dev.yaml → nais/nais-dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ apiVersion: "nais.io/v1alpha1"
kind: "Application"
metadata:
name: dinesykmeldte-backend
namespace: teamsykmelding
namespace: team-esyfo
labels:
team: teamsykmelding
team: team-esyfo
spec:
image: {{ image }}
gcp:
Expand Down Expand Up @@ -62,9 +62,6 @@ spec:
enabled: true
tenant: trygdeetaten.no
accessPolicy:
inbound:
rules:
- application: dinesykmeldte
outbound:
rules:
- application: flex-syketilfelle
Expand Down
12 changes: 8 additions & 4 deletions src/main/kotlin/no/nav/syfo/Application.kt
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,14 @@ package no.nav.syfo
import io.ktor.server.application.Application
import io.ktor.server.engine.embeddedServer
import io.ktor.server.netty.Netty
import no.nav.syfo.plugins.configureContentNegotiation
import no.nav.syfo.plugins.configureDependencies
import no.nav.syfo.plugins.configureLifecycleHooks
import no.nav.syfo.plugins.configureNaisResources
import no.nav.syfo.plugins.configurePrometheus
import no.nav.syfo.plugins.configureRouting
import no.nav.syfo.plugins.configureRunningTasks
import no.nav.syfo.plugins.setupAuth
import org.koin.ktor.ext.get

fun main() {
Expand All @@ -16,10 +20,10 @@ fun main() {
fun Application.module() {
configureDependencies()
configurePrometheus()
// configureContentNegotiation()
// setupAuth(get())
configureContentNegotiation()
setupAuth(get())
configureNaisResources(get())
configureLifecycleHooks(get())
// configureRouting()
// configureRunningTasks(get(), get())
configureRouting()
configureRunningTasks(get(), get())
}
12 changes: 2 additions & 10 deletions src/main/kotlin/no/nav/syfo/Environment.kt
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ data class Environment(
val applicationName: String = getEnvVar("NAIS_APP_NAME", "dinesykmeldte-backend"),
val tokenXWellKnownUrl: String = getEnvVar("TOKEN_X_WELL_KNOWN_URL"),
val dineSykmeldteBackendTokenXClientId: String = getEnvVar("TOKEN_X_CLIENT_ID"),
val databaseUsername: String = getEnvVar("NAIS_DATABASE_USERNAME"),
val databasePassword: String = getEnvVar("NAIS_DATABASE_PASSWORD"),
val dbHost: String = getEnvVar("NAIS_DATABASE_HOST"),
val dbPort: String = getEnvVar("NAIS_DATABASE_PORT"),
val dbName: String = getEnvVar("NAIS_DATABASE_DATABASE"),
val cluster: String = getEnvVar("NAIS_CLUSTER_NAME"),
val nlResponseTopic: String = "teamsykmelding.syfo-narmesteleder",
val pdlGraphqlPath: String = getEnvVar("PDL_GRAPHQL_PATH"),
Expand All @@ -25,11 +20,8 @@ data class Environment(
getEnvVar("SYKETILLFELLE_ENDPOINT_URL", "http://flex-syketilfelle.flex"),
val syketilfelleScope: String = getEnvVar("SYKETILLFELLE_SCOPE"),
val electorPath: String = getEnvVar("ELECTOR_PATH"),
) {
fun jdbcUrl(): String {
return "jdbc:postgresql://$dbHost:$dbPort/$dbName"
}
}
val dbUrl: String = getEnvVar("NAIS_DATABASE_JDBC_URL"),
)

fun getEnvVar(varName: String, defaultValue: String? = null) =
System.getenv(varName)
Expand Down
11 changes: 5 additions & 6 deletions src/main/kotlin/no/nav/syfo/application/database/Database.kt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import java.net.ConnectException
import java.net.SocketException
import java.sql.Connection
import java.sql.ResultSet
import javax.sql.DataSource
import no.nav.syfo.Environment
import no.nav.syfo.util.logger
import org.flywaydb.core.Flyway
Expand All @@ -29,9 +30,7 @@ class Database(private val env: Environment, retries: Long = 30, sleepTime: Long
tempDatasource =
HikariDataSource(
HikariConfig().apply {
jdbcUrl = env.jdbcUrl()
username = env.databaseUsername
password = env.databasePassword
jdbcUrl = env.dbUrl
maximumPoolSize = 5
minimumIdle = 3
isAutoCommit = false
Expand All @@ -54,13 +53,13 @@ class Database(private val env: Environment, retries: Long = 30, sleepTime: Long
throw RuntimeException("Could not connect to DB")
}
dataSource = tempDatasource
runFlywayMigrations()
runFlywayMigrations(dataSource)
}

private fun runFlywayMigrations() =
private fun runFlywayMigrations(dataSource: DataSource) =
Flyway.configure().run {
locations("db")
dataSource(env.jdbcUrl(), env.databaseUsername, env.databasePassword)
dataSource(dataSource)
load().migrate()
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class CommonKafkaService(
listOf(
environment.narmestelederLeesahTopic,
environment.sendtSykmeldingTopic,
environment.sykepengesoknadTopic,
// environment.sykepengesoknadTopic,
environment.hendelserTopic,
),
)
Expand Down
6 changes: 3 additions & 3 deletions src/main/kotlin/no/nav/syfo/plugins/DependencyInjection.kt
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@ fun Application.configureDependencies() {

modules(
applicationStateModule(),
/*environmentModule(),
environmentModule(),
httpClient(),
authModule(),
databaseModule(),
servicesModule(),
commonKafkaConsumer(),*/
commonKafkaConsumer(),
)
}
}
Expand Down Expand Up @@ -105,7 +105,7 @@ private fun commonKafkaConsumer() = module {
it[ConsumerConfig.AUTO_OFFSET_RESET_CONFIG] = "none"
it[ConsumerConfig.MAX_POLL_RECORDS_CONFIG] = 100
}
.toConsumerConfig("dinesykmeldte-backend", StringDeserializer::class),
.toConsumerConfig("esyfo-dinesykmeldte-backend", StringDeserializer::class),
StringDeserializer(),
StringDeserializer(),
)
Expand Down
4 changes: 1 addition & 3 deletions src/test/kotlin/no/nav/syfo/util/TestDb.kt
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ class TestDb private constructor() {

psqlContainer.start()
val mockEnv = mockk<Environment>(relaxed = true)
every { mockEnv.databaseUsername } returns "username"
every { mockEnv.databasePassword } returns "password"
every { mockEnv.jdbcUrl() } returns psqlContainer.jdbcUrl
every { mockEnv.dbUrl } returns psqlContainer.jdbcUrl
database = Database(mockEnv)
} catch (ex: Exception) {
throw ex
Expand Down

0 comments on commit 56300b8

Please sign in to comment.