Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legge til arbeidssøker søknad i ny modernisert flyt. med feturetoggle #1827

Merged
merged 10 commits into from
Jan 20, 2025

Conversation

marcuasc
Copy link
Contributor

@marcuasc marcuasc commented Jan 15, 2025

Hvorfor er denne endringen nødvendig? ✨

Legge til arbeidsøkerskjema i ny flyt.

  • Egen funksjon SendInnArbeidssøkerSkjemaFamiliePdf for å bruke vår nye flyt (søknadskvittering)
  • feature toggle for å bruke ny eller eksisterende flyt

@marcuasc marcuasc marked this pull request as ready for review January 16, 2025 09:03
@marcuasc marcuasc requested a review from a team as a code owner January 16, 2025 09:03
Copy link

@fredrikmork fredrikmork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, små pirkekommentarer :D

src/arbeidssøkerskjema/innsending/api.ts Show resolved Hide resolved
mappetSkjema: Record<string, object>
) => {
try {
const brukModernisertFlyt = toggles[ToggleName.visNyInnsendingsknapp];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pirk: utenfor try-catch

src/arbeidssøkerskjema/steg/2-Oppsummering.tsx Outdated Show resolved Hide resolved
@marcuasc marcuasc merged commit 0fe64d8 into main Jan 20, 2025
3 checks passed
@marcuasc marcuasc deleted the arbeidsokerskjema-ny-flyt branch January 20, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants